Updated Apache HTTP documentation#580
Merged
yqlu merged 3 commits intoGoogleCloudPlatform:masterfrom Jul 14, 2023
Merged
Conversation
yqlu
approved these changes
Jul 14, 2023
Collaborator
yqlu
left a comment
yqlu
left a comment
There was a problem hiding this comment.
I tested the new config in my toy cluster and verified that scraping metrics worked OOTB. Thanks for making this change!
Another note, I didn't see the dashboard appear in the Integrations tab, as I believe we would expect.
Good catch! Looks like that's because this integration is still marked as "HIDDEN". Can you change line 3 of prometheus_metadata.yaml from HIDDEN to GA? Seems like all the other prometheus integrations are correctly marked already, and only this one fell between the cracks.
algchoo
added a commit
to observIQ/monitoring-dashboard-samples
that referenced
this pull request
Aug 15, 2023
* removed args for the exporter due to them all being default values, updated min version * updated the args to include web.listen-address which replaced telemetry.address * updated launch_stage to GA for apache http metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Details
In the latest version of the exporter, the
--telemetry.addressflag is replaced by--web.listen-address. Wasn't initially clear to me from the docker container documentation and the github documentation was more helpful. I thought it initially had something to do with the flags having a certain number of dashes and I noticed we we're using default values, so I just removed the args, but that wasn't the issue.Another note, I didn't see the dashboard appear in the Integrations tab, as I believe we would expect. I was able to verify that metrics were flowing using a clone of the dashboard.